Bug for SSL
- kirblam
-
Topic Author
- Offline
- New Member
-
Less
More
- Posts: 6
- Thank you received: 0
7 years 1 month ago #313
by kirblam
Bug for SSL was created by kirblam
Hey, this issue may extend to other templates. I didn't install the latest version of Kascetic *but* I downloaded it, unzipped it and found the same issue.
In initialize.php:
$document->addStyleSheet( ' fonts.googleapis.com/css?family='.$googlefont .'' );
The hardcoding of 'http' means that any kunena page responding with HTTPS will show issues. Depending on the browser, it may not even try to render it.
Changing to
$document->addStyleSheet( '//fonts.googleapis.com/css?family='.$googlefont.'' );
...appears to fix the issue but if that's not good enough, you could detect the protocol and prepend 'https:' or 'http:' accordingly.
Thanks
JK
In initialize.php:
$document->addStyleSheet( ' fonts.googleapis.com/css?family='.$googlefont .'' );
The hardcoding of 'http' means that any kunena page responding with HTTPS will show issues. Depending on the browser, it may not even try to render it.
Changing to
$document->addStyleSheet( '//fonts.googleapis.com/css?family='.$googlefont.'' );
...appears to fix the issue but if that's not good enough, you could detect the protocol and prepend 'https:' or 'http:' accordingly.
Thanks
JK
- Eugene S.
-
- Offline
- Administrator
-
7 years 1 month ago #314
by Eugene S.
Like our extensions for Kunena?
Add your voice to the JED listing with a 100 score review: bit.ly/2cIg8pF
Thanks!
Replied by Eugene S. on topic Re: Bug for SSL
Dear JK,
Thank you very much for reporting about this issue.
All templates just been updated with this fix.
Have a nice day!
Eugene.
Thank you very much for reporting about this issue.
All templates just been updated with this fix.
Have a nice day!
Eugene.
Like our extensions for Kunena?
Add your voice to the JED listing with a 100 score review: bit.ly/2cIg8pF
Thanks!
Moderators: Eugene S.